Get sample_app running on Android again

Get sample_app running on Android again

R=viettrungluu@chromium.org, viettrungluu
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264559

[DaveMoore, 2014-04-16 23:00:36]

cleanup

[viettrungluu, 2014-04-17 00:10:16]

Does it still work on other platforms after this change?

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_examples.gypi
File mojo/mojo_examples.gypi (left):

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:11: # TODO(darin): we should not be linking against
these libraries!
Are you sure you want to remove darin's TODO here?

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_public.gypi
File mojo/mojo_public.gypi (right):

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:25: }],
"}]," should be indented one level more, and followed by a line with a "]," (at
the indent level of the current "}],").

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:26: ]},
And this line should just be a "},".

[DaveMoore, 2014-04-17 14:07:48]

Address review comments

[DaveMoore, 2014-04-17 14:10:47]

It at least continues to run on linux.

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_examples.gypi
File mojo/mojo_examples.gypi (left):

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:11: # TODO(darin): we should not be linking against
these libraries!
I think so. The app itself uses Size, which comes from gfx_geometry. I took his
comment to be about the gfx / gl stuff. 
On 2014/04/17 00:10:17, viettrungluu wrote:
> Are you sure you want to remove darin's TODO here?

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_public.gypi
File mojo/mojo_public.gypi (right):

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:25: }],
On 2014/04/17 00:10:17, viettrungluu wrote:
> "}]," should be indented one level more, and followed by a line with a "],"
(at
> the indent level of the current "}],").

Done.

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:26: ]},
On 2014/04/17 00:10:17, viettrungluu wrote:
> And this line should just be a "},".

Done.

[vtl, 2014-04-17 14:54:15]

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_examples.gypi
File mojo/mojo_examples.gypi (left):

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:11: # TODO(darin): we should not be linking against
these libraries!
On 2014/04/17 14:10:48, DaveMoore wrote:
> I think so. The app itself uses Size, which comes from gfx_geometry. I took
his
> comment to be about the gfx / gl stuff. 

I suspect his comment applies to everything starting with "..", but you should
clarify with him.

> On 2014/04/17 00:10:17, viettrungluu wrote:
> > Are you sure you want to remove darin's TODO here?
>

https://codereview.chromium.org/240003006/diff/40001/mojo/mojo_public.gypi
File mojo/mojo_public.gypi (right):

https://codereview.chromium.org/240003006/diff/40001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:25: }
}],

https://codereview.chromium.org/240003006/diff/40001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:27: ]},
},

[DaveMoore, 2014-04-17 17:05:05]

Address review comments

[DaveMoore, 2014-04-17 17:06:57]

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_examples.gypi
File mojo/mojo_examples.gypi (left):

https://codereview.chromium.org/240003006/diff/20001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:11: # TODO(darin): we should not be linking against
these libraries!
On 2014/04/17 14:54:15, vtl wrote:
> On 2014/04/17 14:10:48, DaveMoore wrote:
> > I think so. The app itself uses Size, which comes from gfx_geometry. I took
> his
> > comment to be about the gfx / gl stuff. 
> 
> I suspect his comment applies to everything starting with "..", but you should
> clarify with him.
> 
> > On 2014/04/17 00:10:17, viettrungluu wrote:
> > > Are you sure you want to remove darin's TODO here?
> > 
> 

Done.

https://codereview.chromium.org/240003006/diff/40001/mojo/mojo_public.gypi
File mojo/mojo_public.gypi (right):

https://codereview.chromium.org/240003006/diff/40001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:25: }
On 2014/04/17 14:54:15, vtl wrote:
> }],

Done.

https://codereview.chromium.org/240003006/diff/40001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:27: ]},
On 2014/04/17 14:54:15, vtl wrote:
> },

Done.

[viettrungluu, 2014-04-17 17:19:08]

lgtm

[DaveMoore, 2014-04-17 17:27:03]

Committed patchset #4 manually as r264559 (presubmit successful).