Issue 240003002: Add unit test for GlyphPageTreeNode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 240003002: Add unit test for GlyphPageTreeNode. (Closed)

Created:
6 years, 8 months ago by Kunihiko Sakamoto

Modified:
6 years, 8 months ago

Reviewers:
eae

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis, dglazkov

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add unit test for GlyphPageTreeNode. This patch also moves the functionality of GlyphPage::fill() to SimpleFontData::fillGlyphPage(). This new method is overridden by the fake SimpleFontData class used in GlyphPageTreeNodeTest. BUG=none TEST=blink_platform_unittests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171825

Patch Set 1 : #

Patch Set 2 : more tests #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+302 lines, -254 lines)			Patch
M	Source/platform/blink_platform.gyp	View		3 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/platform/blink_platform.gypi	View		3 chunks	+1 line, -2 lines	0 comments	Download
M	Source/platform/fonts/GlyphPage.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/platform/fonts/GlyphPageTreeNode.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
A	Source/platform/fonts/GlyphPageTreeNodeTest.cpp	View	1	1 chunk	+128 lines, -0 lines	0 comments	Download
M	Source/platform/fonts/SimpleFontData.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
D	Source/platform/fonts/mac/GlyphPageTreeNodeMac.cpp	View		1 chunk	+0 lines, -179 lines	0 comments	Download
M	Source/platform/fonts/mac/SimpleFontDataCoreText.cpp	View		2 chunks	+143 lines, -0 lines	0 comments	Download
D	Source/platform/fonts/skia/GlyphPageTreeNodeSkia.cpp	View		1 chunk	+0 lines, -65 lines	0 comments	Download
M	Source/platform/fonts/skia/SimpleFontDataSkia.cpp	View		2 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Kunihiko Sakamoto

The CQ bit was checked by ksakamoto@chromium.org

6 years, 8 months ago (2014-04-17 00:38:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/240003002/60001

6 years, 8 months ago (2014-04-17 00:38:57 UTC) #4

Message was sent while issue was closed.

Change committed as 171825

Expand Messages | Collapse Messages