Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2400023002: [layoutng] Refactor NGBox::Layout (Closed)

Created:
4 years, 2 months ago by cbiesinger
Modified:
4 years, 2 months ago
Reviewers:
Gleb Lanbin, eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Refactor NGBox::Layout Move some of the code into two new functions to make everything more readable. R=eae@chromium.org,glebl@chromium.org BUG=635619 Committed: https://crrev.com/6b4f50b8ae18a17eb46c45f81c025dc1e2b1db9f Cr-Commit-Position: refs/heads/master@{#423722}

Patch Set 1 #

Patch Set 2 : fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -49 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_box.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 1 2 chunks +59 lines, -49 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
cbiesinger
4 years, 2 months ago (2016-10-06 21:09:26 UTC) #1
eae
Nice, LGTM
4 years, 2 months ago (2016-10-06 21:36:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400023002/20001
4 years, 2 months ago (2016-10-06 21:36:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 23:15:46 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 23:17:42 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b4f50b8ae18a17eb46c45f81c025dc1e2b1db9f
Cr-Commit-Position: refs/heads/master@{#423722}

Powered by Google App Engine
This is Rietveld 408576698