Force garbage collection after running any unit tests that initialize WebViews.

chrome/test/render_view_test.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/render_view_test.h"
 
 #include "chrome/browser/extensions/extension_function_dispatcher.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/native_web_keyboard_event.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/renderer_preferences.h"
 #include "chrome/renderer/extensions/event_bindings.h"
 #include "chrome/renderer/extensions/extension_process_bindings.h"
 #include "chrome/renderer/extensions/js_only_v8_extensions.h"
 #include "chrome/renderer/extensions/renderer_extension_bindings.h"
 #include "chrome/renderer/renderer_main_platform_delegate.h"
 #include "webkit/api/public/WebFrame.h"
 #include "webkit/api/public/WebInputEvent.h"
 #include "webkit/api/public/WebKit.h"
 #include "webkit/api/public/WebScriptSource.h"
 #include "webkit/api/public/WebURLRequest.h"
 #include "webkit/glue/webview.h"
+#include "webkit/glue/webkit_glue.h"
 
 using WebKit::WebFrame;
 using WebKit::WebScriptSource;
 using WebKit::WebString;
 using WebKit::WebURLRequest;
 
 namespace {
 const int32 kRouteId = 5;
 const int32 kOpenerId = 7;
 }  // namespace
@@ skipping 28 matching lines @@
 #if defined(OS_WIN)
   command_line_.reset(new CommandLine(std::wstring()));
 #elif defined(OS_POSIX)
   command_line_.reset(new CommandLine(std::vector<std::string>()));
 #endif
   params_.reset(new MainFunctionParams(*command_line_, *sandbox_init_wrapper_,
                                        NULL));
   platform_.reset(new RendererMainPlatformDelegate(*params_));
   platform_->PlatformInitialize();
 
+  // Setting flags and really doing anything with WebKit is fairly fragile and
+  // hacky, but this is the world we live in...
+  webkit_glue::SetJavaScriptFlags(L" --expose-gc");
   WebKit::initialize(&webkitclient_);
   WebKit::registerExtension(BaseJsV8Extension::Get());
   WebKit::registerExtension(JsonSchemaJsV8Extension::Get());
   WebKit::registerExtension(EventBindings::Get());
   WebKit::registerExtension(ExtensionApiTestV8Extension::Get());
   WebKit::registerExtension(ExtensionProcessBindings::Get());
   WebKit::registerExtension(RendererExtensionBindings::Get());
   EventBindings::SetRenderThread(&render_thread_);
 
   // TODO(aa): Should some of this go to some other inheriting class?
@@ skipping 12 matching lines @@
 
   // This needs to pass the mock render thread to the view.
   view_ = RenderView::Create(&render_thread_, NULL, NULL, kOpenerId,
                              RendererPreferences(), WebPreferences(),
                              new SharedRenderViewCounter(0), kRouteId);
 
   // Attach a pseudo keyboard device to this object.
   mock_keyboard_.reset(new MockKeyboard());
 }
 void RenderViewTest::TearDown() {
+  // Try very hard to collect garbage before shutting down.
+  GetMainFrame()->collectGarbage();
+  GetMainFrame()->collectGarbage();
+
   render_thread_.SendCloseMessage();
 
   // Run the loop so the release task from the renderwidget executes.
   ProcessPendingMessages();

[darin (slow to review), 2009/09/25 19:43:33]

i might be slightly better to call GC after this line.  that way any work
performed by those tasks have a chance to release object references that might
be intertwined with GC'able objects.  i'm thinking about JS timers, etc.

[jorlow, 2009/09/25 19:56:11]

Not possible.  GetMainThread() won't work at this point.

 
   EventBindings::SetRenderThread(NULL);
 
   view_ = NULL;
 
   mock_process_.reset();
 
   // After resetting the view_ and mock_process_ we may get some new tasks
   // which need to be processed before shutting down WebKit
   // (http://crbug.com/21508).
@@ skipping 49 matching lines @@
   keyup_message->WriteData(reinterpret_cast<const char*>(&keyup_event),
                            sizeof(WebKit::WebKeyboardEvent));
   view_->OnHandleInputEvent(*keyup_message);
 
   return length;
 #else
   NOTIMPLEMENTED();
   return L'\0';
 #endif
 }