Issue 24000003: [Android] Set V8 is_memory_constrained ResourceConstraint on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24000003: [Android] Set V8 is_memory_constrained ResourceConstraint on Android. (Closed)

Created:
7 years, 3 months ago by rmcilroy

Modified:
7 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Set V8 is_memory_constrained ResourceConstraint on Android. Set the is_memory_constrained ResourceConstraint flag on low end Android devices. BUG=280984

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	content/renderer/render_thread_impl.cc	View		2 chunks	+8 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

https://codereview.chromium.org/24000003/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/24000003/diff/1/content/renderer/render_thread_impl.cc#newcode330 content/renderer/render_thread_impl.cc:330: resourceConstraints.set_memory_constrained(&is_memory_constrained); can you please show me where this API ...

7 years, 3 months ago (2013-09-06 00:24:04 UTC) #2

rmcilroy

7 years, 3 months ago (2013-09-06 16:35:09 UTC) #3

On 2013/09/06 00:24:04, jamesr wrote:
>
https://codereview.chromium.org/24000003/diff/1/content/renderer/render_threa...
> File content/renderer/render_thread_impl.cc (right):
> 
>
https://codereview.chromium.org/24000003/diff/1/content/renderer/render_threa...
> content/renderer/render_thread_impl.cc:330:
> resourceConstraints.set_memory_constrained(&is_memory_constrained);
> can you please show me where this API is provided?  I don't see it in
> https://code.google.com/p/v8/source/browse/trunk/include/v8.h

It's not landed yet, but the CL to make this change is here:
https://codereview.chromium.org/23464022/.  This was LGTMed when I sent you this
patchset, but has been un-LGTMed due to changes I made to enable the setting to
be done in Chrome rather than Blink.  Since there seems to be disagreement on
these various CLs about which layers (v8/blink/chromium) this should be done at,
I'll send round an email with all the reviewers and try and reach a consensus
before continuing.

Expand Messages | Collapse Messages