Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2399993004: git cl try: --use-rietveld no longer supported. (Closed)

Created:
4 years, 2 months ago by tandrii(chromium)
Modified:
4 years, 2 months ago
Reviewers:
estaab, nodir
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M git_cl.py View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
estaab
lgtm
4 years, 2 months ago (2016-10-07 15:01:16 UTC) #6
nodir
https://codereview.chromium.org/2399993004/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2399993004/diff/1/git_cl.py#newcode4798 git_cl.py:4798: if not options.use_rietveld: what about this? there may be ...
4 years, 2 months ago (2016-10-07 17:05:52 UTC) #7
tandrii(chromium)
https://codereview.chromium.org/2399993004/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2399993004/diff/1/git_cl.py#newcode4798 git_cl.py:4798: if not options.use_rietveld: On 2016/10/07 17:05:51, nodir wrote: > ...
4 years, 2 months ago (2016-10-09 10:50:11 UTC) #8
tandrii(chromium)
4 years, 2 months ago (2016-10-09 10:50:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399993004/20001
4 years, 2 months ago (2016-10-10 10:20:06 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 10:23:05 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/8e22954683ff49...

Powered by Google App Engine
This is Rietveld 408576698