Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2399993003: [Mac] Don't unhide Chrome when a notification is displayed. (Closed)

Created:
4 years, 2 months ago by Sidney San Martín
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Don't unhide Chrome when a notification is displayed. Right now, if Chrome was hidden (cmd+h) and a notification comes in, the whole app unhides. Calling setHidden:YES on the notification window lets it be visible when Chrome is hidden, and the -[NSWindow order*] methods respect it by not unhiding the app. BUG=653266 Committed: https://crrev.com/a8cad7b0b4254bec43a95c58509f636236b262f2 Cr-Commit-Position: refs/heads/master@{#423856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/message_center/cocoa/popup_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sidney San Martín
4 years, 2 months ago (2016-10-07 13:24:02 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-07 14:29:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399993003/1
4 years, 2 months ago (2016-10-07 14:31:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 14:39:51 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 14:42:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8cad7b0b4254bec43a95c58509f636236b262f2
Cr-Commit-Position: refs/heads/master@{#423856}

Powered by Google App Engine
This is Rietveld 408576698