Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2399993002: Remove (Native)Widget::StackBelow(). (Closed)

Created:
4 years, 2 months ago by Elliot Glaysher
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove (Native)Widget::StackBelow(). This method is never used and is unimplemented on most platforms. BUG=599570 Committed: https://crrev.com/e5d16bbccdf0ddaa5be57798c11c9b59a5acfcfa Cr-Commit-Position: refs/heads/master@{#423717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M ui/views/mus/native_widget_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/widget/native_widget_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/native_widget_private.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/widget.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Elliot Glaysher
The best way to port a method to a new platform is to just delete ...
4 years, 2 months ago (2016-10-06 21:00:34 UTC) #4
sky
:) Please find more code like this! LGTM
4 years, 2 months ago (2016-10-06 22:25:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399993002/1
4 years, 2 months ago (2016-10-06 22:45:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 22:52:05 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 22:54:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5d16bbccdf0ddaa5be57798c11c9b59a5acfcfa
Cr-Commit-Position: refs/heads/master@{#423717}

Powered by Google App Engine
This is Rietveld 408576698