Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2399983004: Set fixed size to true on NewTabPageRecyclerView. (Closed)

Created:
4 years, 2 months ago by Michael van Ouwerkerk
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set fixed size to true on NewTabPageRecyclerView. Its size is not affected by the adapter contents so this can be true, allowing for internal optimizations. Committed: https://crrev.com/32a96b17fe626846a76e5f87514656d024ad3969 Cr-Commit-Position: refs/heads/master@{#423854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 2 months ago (2016-10-07 13:50:23 UTC) #4
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-10-07 14:01:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399983004/1
4 years, 2 months ago (2016-10-07 14:24:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 14:29:32 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 14:32:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32a96b17fe626846a76e5f87514656d024ad3969
Cr-Commit-Position: refs/heads/master@{#423854}

Powered by Google App Engine
This is Rietveld 408576698