DescriptionRevert of 📰 Spacing and fixes for the sign in promo (patchset #2 id:20001 of https://codereview.chromium.org/2396863003/ )
Reason for revert:
Reverting due to test failures in chrome_public_test_apk
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36518
failures:
org.chromium.chrome.browser.widget.OverviewListLayoutTest#testCloseAllIncognito
org.chromium.chrome.browser.widget.OverviewListLayoutTest#testModelSwitcherVisibility
Original issue's description:
> [NTP Client] Spacing and fixes for the sign in promo
>
> - Fixes an exception when only the sign in promo is present on the NTP
> and we attempt to make it peek
>
> - Adds 20dp space between the promo and the status card if present
>
> - Fixes to the bottom space calculation related to the dismissal of
> sibling elements.
>
> Preview: https://goo.gl/photos/94hhXK5rygGamFqt7
>
> BUG=649670, 652578
>
> Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8
> Cr-Commit-Position: refs/heads/master@{#423525}
TBR=bauerb@chromium.org,dgn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=649670, 652578
Committed: https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7
Cr-Commit-Position: refs/heads/master@{#423644}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|