Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2399983002: Revert of 📰 Spacing and fixes for the sign in promo (Closed)

Created:
4 years, 2 months ago by nasko
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer, dgn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 📰 Spacing and fixes for the sign in promo (patchset #2 id:20001 of https://codereview.chromium.org/2396863003/ ) Reason for revert: Reverting due to test failures in chrome_public_test_apk https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36518 failures: org.chromium.chrome.browser.widget.OverviewListLayoutTest#testCloseAllIncognito org.chromium.chrome.browser.widget.OverviewListLayoutTest#testModelSwitcherVisibility Original issue's description: > [NTP Client] Spacing and fixes for the sign in promo > > - Fixes an exception when only the sign in promo is present on the NTP > and we attempt to make it peek > > - Adds 20dp space between the promo and the status card if present > > - Fixes to the bottom space calculation related to the dismissal of > sibling elements. > > Preview: https://goo.gl/photos/94hhXK5rygGamFqt7 > > BUG=649670, 652578 > > Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8 > Cr-Commit-Position: refs/heads/master@{#423525} TBR=bauerb@chromium.org,dgn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=649670, 652578 Committed: https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7 Cr-Commit-Position: refs/heads/master@{#423644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -96 lines) Patch
M chrome/android/java/res/values/dimens.xml View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 8 chunks +10 lines, -21 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 7 chunks +16 lines, -44 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java View 5 chunks +3 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nasko
Created Revert of 📰 Spacing and fixes for the sign in promo
4 years, 2 months ago (2016-10-06 20:10:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399983002/1
4 years, 2 months ago (2016-10-06 20:11:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 20:12:40 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7 Cr-Commit-Position: refs/heads/master@{#423644}
4 years, 2 months ago (2016-10-06 20:15:27 UTC) #7
dgn
4 years, 2 months ago (2016-10-07 13:02:17 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2397573009/ by dgn@chromium.org.

The reason for reverting is: Reland.

Powered by Google App Engine
This is Rietveld 408576698