third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc - Issue 2399963002: [layoutng] margin: auto support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

Issue 2399963002: [layoutng] margin: auto support (Closed)

Patch Set: one more test now passes! Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

index cbf03b794b40330d49c43a4c76cf5990b2c14a4d..560b03f52028e2f1d1eb7b44394c1899681dd975 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

@@ -80,6 +80,8 @@ bool NGBlockLayoutAlgorithm::Layout(const NGConstraintSpace* constraint_space,

*constraint_space_for_children_, *current_child_->Style(),

constraint_space_for_children_->WritingMode(),

constraint_space_for_children_->Direction());

+ ApplyAutoMargins(*constraint_space_for_children_,

+ *current_child_->Style(), *fragment, child_margins);

const NGBoxStrut margins =

CollapseMargins(*constraint_space, child_margins, *fragment);