Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: components/sync/api_impl/attachments/attachment_service_impl.cc

Issue 2399953002: [Sync] Move attachments code out of core/. (Closed)
Patch Set: Address comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/api_impl/attachments/attachment_service_impl.cc
diff --git a/components/sync/core_impl/attachments/attachment_service_impl.cc b/components/sync/api_impl/attachments/attachment_service_impl.cc
similarity index 92%
rename from components/sync/core_impl/attachments/attachment_service_impl.cc
rename to components/sync/api_impl/attachments/attachment_service_impl.cc
index 2b863fd5f5256c72595077ca488898bc60c7c3f4..7a1ed9018377c65837030b3e7a2a2690085a0654 100644
--- a/components/sync/core_impl/attachments/attachment_service_impl.cc
+++ b/components/sync/api_impl/attachments/attachment_service_impl.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "components/sync/core/attachments/attachment_service_impl.h"
+#include "components/sync/api_impl/attachments/attachment_service_impl.h"
#include <iterator>
#include <utility>
@@ -13,8 +13,8 @@
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
#include "components/sync/api/attachments/attachment.h"
-#include "components/sync/core/attachments/fake_attachment_downloader.h"
-#include "components/sync/core/attachments/fake_attachment_uploader.h"
+#include "components/sync/engine/attachments/fake_attachment_downloader.h"
+#include "components/sync/engine/attachments/fake_attachment_uploader.h"
namespace syncer {
@@ -142,22 +142,6 @@ AttachmentServiceImpl::~AttachmentServiceImpl() {
net::NetworkChangeNotifier::RemoveNetworkChangeObserver(this);
}
-// Static.
-std::unique_ptr<AttachmentService> AttachmentServiceImpl::CreateForTest() {
- std::unique_ptr<AttachmentStore> attachment_store =
- AttachmentStore::CreateInMemoryStore();
- std::unique_ptr<AttachmentUploader> attachment_uploader(
- new FakeAttachmentUploader);
- std::unique_ptr<AttachmentDownloader> attachment_downloader(
- new FakeAttachmentDownloader());
- std::unique_ptr<AttachmentService> attachment_service(
- new AttachmentServiceImpl(
- attachment_store->CreateAttachmentStoreForSync(),
- std::move(attachment_uploader), std::move(attachment_downloader),
- NULL, base::TimeDelta(), base::TimeDelta()));
- return attachment_service;
-}
-
void AttachmentServiceImpl::GetOrDownloadAttachments(
const AttachmentIdList& attachment_ids,
const GetOrDownloadCallback& callback) {

Powered by Google App Engine
This is Rietveld 408576698