Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(1255)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: components/sync/api_impl/attachments/DEPS
Issue
2399953002
:
[Sync] Move attachments code out of core/. (Closed)
Patch Set: Address comments.
Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc
chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc
chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
chrome/browser/chromeos/preferences_unittest.cc
chrome/browser/extensions/api/sessions/sessions_apitest.cc
chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc
chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc
chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
chrome/browser/themes/theme_syncable_service_unittest.cc
chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc
chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc
chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc
components/browser_sync/profile_sync_components_factory_impl.cc
components/dom_distiller/core/dom_distiller_store_unittest.cc
components/history/core/browser/history_service_unittest.cc
components/history/core/browser/typed_url_syncable_service_unittest.cc
components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
components/sync/BUILD.gn
components/sync/api/DEPS
components/sync/api/attachments/attachment.cc
components/sync/api/attachments/attachment_service.h
components/sync/api/attachments/attachment_service.cc
components/sync/api/attachments/attachment_service_proxy.h
components/sync/api/attachments/attachment_service_proxy.cc
components/sync/api/attachments/attachment_service_proxy_for_test.h
components/sync/api/attachments/attachment_service_proxy_for_test.cc
components/sync/api/attachments/attachment_service_proxy_unittest.cc
components/sync/api/attachments/attachment_store.cc
components/sync/api/attachments/attachment_store_backend.h
components/sync/api/attachments/attachment_store_backend.cc
components/sync/api/attachments/attachment_unittest.cc
components/sync/api/sync_change_unittest.cc
components/sync/api/sync_data.h
components/sync/api/sync_data_unittest.cc
components/sync/api_impl/DEPS
components/sync/api_impl/attachments/DEPS
components/sync/api_impl/attachments/attachment_service_impl.h
components/sync/api_impl/attachments/attachment_service_impl.cc
components/sync/api_impl/attachments/attachment_service_impl_unittest.cc
components/sync/api_impl/attachments/task_queue.h
components/sync/api_impl/attachments/task_queue_unittest.cc
components/sync/core/attachments/attachment_downloader.h
components/sync/core/attachments/attachment_downloader_impl.h
components/sync/core/attachments/attachment_service.h
components/sync/core/attachments/attachment_service_impl.h
components/sync/core/attachments/attachment_service_proxy.h
components/sync/core/attachments/attachment_service_proxy_for_test.h
components/sync/core/attachments/attachment_store_frontend.h
components/sync/core/attachments/attachment_uploader.h
components/sync/core/attachments/attachment_uploader_impl.h
components/sync/core/attachments/attachment_util.h
components/sync/core/attachments/fake_attachment_downloader.h
components/sync/core/attachments/fake_attachment_uploader.h
components/sync/core/attachments/in_memory_attachment_store.h
components/sync/core/attachments/on_disk_attachment_store.h
components/sync/core/attachments/task_queue.h
components/sync/core_impl/attachments/DEPS
components/sync/core_impl/attachments/attachment_downloader.cc
components/sync/core_impl/attachments/attachment_downloader_impl.cc
components/sync/core_impl/attachments/attachment_downloader_impl_unittest.cc
components/sync/core_impl/attachments/attachment_service.cc
components/sync/core_impl/attachments/attachment_service_impl.cc
components/sync/core_impl/attachments/attachment_service_impl_unittest.cc
components/sync/core_impl/attachments/attachment_service_proxy.cc
components/sync/core_impl/attachments/attachment_service_proxy_for_test.cc
components/sync/core_impl/attachments/attachment_service_proxy_unittest.cc
components/sync/core_impl/attachments/attachment_store_frontend.cc
components/sync/core_impl/attachments/attachment_store_frontend_unittest.cc
components/sync/core_impl/attachments/attachment_store_test_template.h
components/sync/core_impl/attachments/attachment_uploader.cc
components/sync/core_impl/attachments/attachment_uploader_impl.cc
components/sync/core_impl/attachments/attachment_uploader_impl_unittest.cc
components/sync/core_impl/attachments/attachment_util.cc
components/sync/core_impl/attachments/fake_attachment_downloader.cc
components/sync/core_impl/attachments/fake_attachment_downloader_unittest.cc
components/sync/core_impl/attachments/fake_attachment_uploader.cc
components/sync/core_impl/attachments/fake_attachment_uploader_unittest.cc
components/sync/core_impl/attachments/in_memory_attachment_store.cc
components/sync/core_impl/attachments/in_memory_attachment_store_unittest.cc
components/sync/core_impl/attachments/on_disk_attachment_store.cc
components/sync/core_impl/attachments/on_disk_attachment_store_unittest.cc
components/sync/core_impl/attachments/proto/BUILD.gn
components/sync/core_impl/attachments/proto/attachment_store.proto
components/sync/core_impl/attachments/task_queue.cc
components/sync/core_impl/attachments/task_queue_unittest.cc
components/sync/device_info/device_info_sync_service_unittest.cc
components/sync/driver/fake_generic_change_processor.cc
components/sync/driver/generic_change_processor.h
components/sync/driver/generic_change_processor_unittest.cc
components/sync/driver/shared_change_processor_unittest.cc
components/sync/driver/sync_api_component_factory.h
components/sync/driver/sync_api_component_factory_mock.cc
components/sync/engine/DEPS
components/sync/engine/attachments/DEPS
components/sync/engine/attachments/attachment_downloader.h
components/sync/engine/attachments/attachment_downloader.cc
components/sync/engine/attachments/attachment_store_backend.h
components/sync/engine/attachments/attachment_store_backend.cc
components/sync/engine/attachments/attachment_store_frontend.h
components/sync/engine/attachments/attachment_store_frontend.cc
components/sync/engine/attachments/attachment_store_frontend_unittest.cc
components/sync/engine/attachments/attachment_store_test_template.h
components/sync/engine/attachments/attachment_uploader.h
components/sync/engine/attachments/attachment_uploader.cc
components/sync/engine/attachments/attachment_util.h
components/sync/engine/attachments/attachment_util.cc
components/sync/engine/attachments/fake_attachment_downloader.h
components/sync/engine/attachments/fake_attachment_downloader.cc
components/sync/engine/attachments/fake_attachment_downloader_unittest.cc
components/sync/engine/attachments/fake_attachment_uploader.h
components/sync/engine/attachments/fake_attachment_uploader.cc
components/sync/engine/attachments/fake_attachment_uploader_unittest.cc
components/sync/engine/attachments/in_memory_attachment_store.h
components/sync/engine/attachments/in_memory_attachment_store.cc
components/sync/engine/attachments/in_memory_attachment_store_unittest.cc
components/sync/engine/attachments/on_disk_attachment_store.h
components/sync/engine/attachments/on_disk_attachment_store.cc
components/sync/engine/attachments/on_disk_attachment_store_unittest.cc
components/sync/engine_impl/DEPS
components/sync/engine_impl/attachments/DEPS
components/sync/engine_impl/attachments/attachment_downloader_impl.h
components/sync/engine_impl/attachments/attachment_downloader_impl.cc
components/sync/engine_impl/attachments/attachment_downloader_impl_unittest.cc
components/sync/engine_impl/attachments/attachment_uploader_impl.h
components/sync/engine_impl/attachments/attachment_uploader_impl.cc
components/sync/engine_impl/attachments/attachment_uploader_impl_unittest.cc
components/sync/engine_impl/attachments/proto/BUILD.gn
components/sync/engine_impl/attachments/proto/attachment_store.proto
components/sync_sessions/favicon_cache_unittest.cc
components/sync_sessions/lost_navigations_recorder_unittest.cc
components/syncable_prefs/pref_service_syncable_unittest.cc
components/wifi_sync/wifi_credential_syncable_service_unittest.cc
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« components/sync/api_impl/DEPS
('k') |
components/sync/api_impl/attachments/attachment_service_impl.h »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: components/sync/api_impl/attachments/DEPS
diff --git a/ios/net/DEPS b/components/sync/api_impl/attachments/DEPS
similarity index 100%
copy from ios/net/DEPS
copy to components/sync/api_impl/attachments/DEPS
« no previous file with comments
|
« components/sync/api_impl/DEPS
('k') |
components/sync/api_impl/attachments/attachment_service_impl.h »
('j') |
no next file with comments »
Issue 2399953002: [Sync] Move attachments code out of core/. (Closed)
Created 4 years, 2 months ago by maxbogue
Modified 4 years, 2 months ago
Reviewers: skym, Nico, sdefresne
Base URL:
Comments: 11
This is Rietveld
408576698