[Sync] Move attachments code out of core/.

components/sync/driver/generic_change_processor_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/driver/generic_change_processor.h"
 
 #include <stddef.h>
 
 #include <utility>
 
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "components/sync/api/attachments/attachment_id.h"
+#include "components/sync/api/attachments/attachment_service.h"
 #include "components/sync/api/data_type_error_handler_mock.h"
 #include "components/sync/api/fake_syncable_service.h"
 #include "components/sync/api/sync_change.h"
 #include "components/sync/base/model_type.h"
-#include "components/sync/core/attachments/attachment_service_impl.h"
-#include "components/sync/core/attachments/fake_attachment_downloader.h"
-#include "components/sync/core/attachments/fake_attachment_uploader.h"
 #include "components/sync/core/read_node.h"
 #include "components/sync/core/read_transaction.h"
 #include "components/sync/core/sync_encryption_handler.h"
 #include "components/sync/core/test/test_user_share.h"
 #include "components/sync/core/user_share.h"
 #include "components/sync/core/write_node.h"
 #include "components/sync/core/write_transaction.h"
 #include "components/sync/device_info/local_device_info_provider.h"
 #include "components/sync/driver/fake_sync_client.h"
 #include "components/sync/driver/sync_api_component_factory.h"
+#include "components/sync/engine/attachments/fake_attachment_downloader.h"
+#include "components/sync/engine/attachments/fake_attachment_uploader.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace syncer {
 
 namespace {
 
 // A mock that keeps track of attachments passed to UploadAttachments.
-class MockAttachmentService : public AttachmentServiceImpl {
+class MockAttachmentService : public AttachmentService {
  public:
-  MockAttachmentService(
-      std::unique_ptr<AttachmentStoreForSync> attachment_store);
-  ~MockAttachmentService() override;
-  void UploadAttachments(const AttachmentIdList& attachment_ids) override;
-  std::vector<AttachmentIdList>* attachment_id_lists();
+  MockAttachmentService() {}
+  ~MockAttachmentService() override {}
+
+  void GetOrDownloadAttachments(
+      const AttachmentIdList& attachment_ids,
+      const GetOrDownloadCallback& callback) override {}
+
+  void UploadAttachments(const AttachmentIdList& attachment_ids) override {
+    attachment_id_lists_.push_back(attachment_ids);
+  }
+
+  std::vector<AttachmentIdList>* attachment_id_lists() {
+    return &attachment_id_lists_;
+  }
 
  private:
   std::vector<AttachmentIdList> attachment_id_lists_;
 };
 
-MockAttachmentService::MockAttachmentService(
-    std::unique_ptr<AttachmentStoreForSync> attachment_store)
-    : AttachmentServiceImpl(
-          std::move(attachment_store),
-          std::unique_ptr<AttachmentUploader>(new FakeAttachmentUploader),
-          std::unique_ptr<AttachmentDownloader>(new FakeAttachmentDownloader),
-          NULL,
-          base::TimeDelta(),
-          base::TimeDelta()) {}
-
-MockAttachmentService::~MockAttachmentService() {}
-
-void MockAttachmentService::UploadAttachments(
-    const AttachmentIdList& attachment_ids) {
-  attachment_id_lists_.push_back(attachment_ids);
-  AttachmentServiceImpl::UploadAttachments(attachment_ids);
-}
-
-std::vector<AttachmentIdList>* MockAttachmentService::attachment_id_lists() {
-  return &attachment_id_lists_;
-}
-
 // MockSyncApiComponentFactory needed to initialize GenericChangeProcessor and
 // pass MockAttachmentService to it.
 class MockSyncApiComponentFactory : public SyncApiComponentFactory {
  public:
   MockSyncApiComponentFactory() {}
 
   // SyncApiComponentFactory implementation.
   void RegisterDataTypes(
       SyncService* sync_service,
       const RegisterDataTypesMethod& register_platform_types_method) override {}
@@ skipping 21 matching lines @@
       std::unique_ptr<DataTypeErrorHandler> error_handler) override {
     return SyncComponents(nullptr, nullptr);
   }
 
   std::unique_ptr<AttachmentService> CreateAttachmentService(
       std::unique_ptr<AttachmentStoreForSync> attachment_store,
       const UserShare& user_share,
       const std::string& store_birthday,
       ModelType model_type,
       AttachmentService::Delegate* delegate) override {
     std::unique_ptr<MockAttachmentService> attachment_service(

[skym, 2016/10/07 18:22:16]

base::MakeUnique()?

[maxbogue, 2016/10/07 19:21:50]

Done.

-        new MockAttachmentService(std::move(attachment_store)));
+        new MockAttachmentService());
     // GenericChangeProcessor takes ownership of the AttachmentService, but we
     // need to have a pointer to it so we can see that it was used properly.
     // Take a pointer and trust that GenericChangeProcessor does not prematurely
     // destroy it.
     mock_attachment_service_ = attachment_service.get();
     return std::move(attachment_service);
   }
 
   MockAttachmentService* GetMockAttachmentService() {
     return mock_attachment_service_;
@@ skipping 387 matching lines @@
   SyncDataList sync_data = change_processor()->GetAllSyncData(SESSIONS);
   ASSERT_EQ(sync_data.size(), 1U);
   ASSERT_EQ("session tag 2",
             sync_data[0].GetSpecifics().session().session_tag());
   EXPECT_FALSE(SyncDataRemote(sync_data[0]).GetClientTagHash().empty());
 }
 
 }  // namespace
 
 }  // namespace syncer