Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: src/ast/scopes.cc

Issue 2399933005: Fix comment typos (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.cc
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc
index 61fafb1ba18dad6dd7286bd22e899179ff067832..e7b785546e25fe4d684c444084ef970c32c01bd5 100644
--- a/src/ast/scopes.cc
+++ b/src/ast/scopes.cc
@@ -1451,8 +1451,7 @@ void Scope::Print(int n) {
}
void Scope::CheckScopePositions() {
- // A scope is allowed to have invalid positions if it is hidden and has no
- // inner scopes
jwolfe 2016/10/06 19:17:44 The typo here is a bit subtle. A minimal change to
+ // Visible leaf scopes must have real positions.
if (!is_hidden() && inner_scope_ == nullptr) {
CHECK_NE(kNoSourcePosition, start_position());
CHECK_NE(kNoSourcePosition, end_position());
« no previous file with comments | « no previous file | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698