Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2399933003: Revert of Mojoify FetchEvent of Service Worker. (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
clamy, shimazu, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojoify FetchEvent of Service Worker. (patchset #8 id:330001 of https://codereview.chromium.org/2352173004/ ) Reason for revert: Release blocker crash: https://crbug.com/653403 Original issue's description: > Mojoify FetchEvent of Service Worker. > > I'd like to use Mojo to send navigation preload response (crbug.com/649558) from > the browser process to the service worker. But currently we are using the legacy > IPC when the browser process sends the FetchEvent to the service worker. There > will be an ordering issue if we use both the legacy IPC and Mojo IPC. > > To avoid the ordering issue, this CL changes the FetchEvent IPC to use Mojo. > > BUG=629701, 649558 > > Committed: https://crrev.com/bdc8e1e4477f7dcd911528720a50d639be6d39b5 > Cr-Commit-Position: refs/heads/master@{#422996} TBR=shimazu@chromium.org,clamy@chromium.org,horo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629701, 649558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -301 lines) Patch
M content/browser/service_worker/embedded_worker_test_helper.h View 7 chunks +6 lines, -17 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 10 chunks +19 lines, -58 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 3 chunks +5 lines, -20 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 12 chunks +33 lines, -24 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D content/common/service_worker/fetch_event_dispatcher.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
D content/common/service_worker/fetch_event_dispatcher.typemap View 1 chunk +0 lines, -20 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 2 chunks +8 lines, -0 lines 0 comments Download
D content/common/service_worker/service_worker_status_code_traits.h View 1 chunk +0 lines, -25 lines 0 comments Download
D content/common/service_worker/service_worker_status_code_traits.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M content/common/typemaps.gni View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 4 chunks +3 lines, -8 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 9 chunks +8 lines, -57 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dcheng
Created Revert of Mojoify FetchEvent of Service Worker.
4 years, 2 months ago (2016-10-06 18:15:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399933003/1
4 years, 2 months ago (2016-10-06 18:16:23 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/81918) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-06 18:19:41 UTC) #5
dcheng
4 years, 2 months ago (2016-10-06 18:29:44 UTC) #6
Already manually reverted it seems.

Powered by Google App Engine
This is Rietveld 408576698