Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4983)

Unified Diff: build/common.gypi

Issue 239993009: Revert accidental dartium code push (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | chrome/browser/resources/about_version.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index d156799e478d93f3abc90857bf085c824bf08460..ebec615bcbf8ba4d694436c105467d1664c347df 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -420,7 +420,7 @@
'enable_extensions%': 1,
# Enable Google Now.
- 'enable_google_now%': 0,
+ 'enable_google_now%': 1,
# Enable printing support and UI. This variable is used to configure
# which parts of printing will be built. 0 disables printing completely,
@@ -1148,7 +1148,7 @@
# flag allows us to have warnings as errors in general to prevent
# regressions in most modules, while working on the bits that are
# remaining.
- 'win_third_party_warn_as_error%': 'false',
+ 'win_third_party_warn_as_error%': 'true',
# Clang stuff.
'clang%': '<(clang)',
@@ -2727,7 +2727,6 @@
}],
[ 'OS=="mac" or OS=="ios"', {
'xcode_settings': {
- 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO',
'WARNING_CFLAGS!': ['-Wall', '-Wextra'],
},
'conditions': [
« no previous file with comments | « build/all.gyp ('k') | chrome/browser/resources/about_version.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698