Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 239993009: Revert accidental dartium code push (Closed)

Created:
6 years, 8 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
RemcovanVugt84, terry, Nico
CC:
aandrey+blink_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, jochen+watch_chromium.org, paulirish+reviews_chromium.org, pfeldman, vsevik, yurys
Visibility:
Public.

Description

Revert accidental dartium code push This reverts r264517 to r264538 from terry@google.com BUG=none TEST=none NOTRY=true NOTREECHECKS=true TBR=terry@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1851 lines) Patch
M OWNERS View 1 chunk +2 lines, -9 lines 0 comments Download
M android_webview/common/aw_content_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M build/all.gyp View 1 chunk +0 lines, -12 lines 0 comments Download
M build/common.gypi View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/about_version.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/tools/build/mac/verify_order View 1 chunk +0 lines, -2 lines 0 comments Download
M codereview.settings View 1 chunk +9 lines, -3 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/child/simple_webmimeregistry_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/simple_webmimeregistry_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/shell/common/shell_content_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
D dartium_tools/archive.py View 1 chunk +0 lines, -204 lines 0 comments Download
D dartium_tools/build.py View 1 chunk +0 lines, -57 lines 0 comments Download
D dartium_tools/buildbot_annotated_steps.py View 1 chunk +0 lines, -374 lines 0 comments Download
D dartium_tools/export_overrides.py View 1 chunk +0 lines, -6 lines 0 comments Download
D dartium_tools/fetch_reference_build.py View 1 chunk +0 lines, -48 lines 0 comments Download
D dartium_tools/generate_dart_vm_version.py View 1 chunk +0 lines, -34 lines 0 comments Download
D dartium_tools/get_chromium_build.py View 1 chunk +0 lines, -171 lines 0 comments Download
D dartium_tools/print_dart_version.sh View 1 chunk +0 lines, -28 lines 0 comments Download
D dartium_tools/roll_forward.py View 1 chunk +0 lines, -84 lines 0 comments Download
D dartium_tools/roll_webkit.sh View 1 chunk +0 lines, -30 lines 0 comments Download
D dartium_tools/set_reference_build_revision.py View 1 chunk +0 lines, -29 lines 0 comments Download
D dartium_tools/supplement.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
D dartium_tools/test.py View 1 chunk +0 lines, -242 lines 0 comments Download
D dartium_tools/update_deps.py View 1 chunk +0 lines, -226 lines 0 comments Download
D dartium_tools/update_patched_files.py View 1 chunk +0 lines, -27 lines 0 comments Download
D dartium_tools/update_version.py View 1 chunk +0 lines, -40 lines 0 comments Download
D dartium_tools/utils.py View 1 chunk +0 lines, -123 lines 0 comments Download
M net/base/mime_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/mime_util.cc View 8 chunks +0 lines, -20 lines 0 comments Download
M net/base/network_change_notifier_win.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/base/network_change_notifier_win.cc View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-17 16:49:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/239993009/1
6 years, 8 months ago (2014-04-17 16:50:21 UTC) #2
James Cook
The CQ bit was unchecked by jamescook@chromium.org
6 years, 8 months ago (2014-04-17 16:50:58 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-17 16:50:59 UTC) #4
James Cook
Committed patchset #1 manually as r264545 (tree was closed).
6 years, 8 months ago (2014-04-17 16:51:01 UTC) #5
Nico
lgtm
6 years, 8 months ago (2014-04-17 17:13:17 UTC) #6
RemcovanVugt84
4 years, 5 months ago (2016-07-06 22:25:43 UTC) #8
Message was sent while issue was closed. 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698