Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 239993004: Ignore java files in ThirdParty directories (Closed)

Created:
6 years, 8 months ago by sdefresne
Modified:
6 years, 7 months ago
Reviewers:
brettw, msarda
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Ignore java files in ThirdParty directories Chrome on iOS uses some third party code from a directory named ThirdParty that includes java files. They are not used but cause warnings when running tools/checkdeps/checkdeps.py instead of being ignored. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268191

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/checkdeps/java_checker.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
sdefresne
Please have a look.
6 years, 8 months ago (2014-04-16 13:27:28 UTC) #1
msarda
lgtm
6 years, 8 months ago (2014-04-16 13:28:35 UTC) #2
sdefresne
+brettw for OWNERS
6 years, 8 months ago (2014-04-16 13:29:12 UTC) #3
sdefresne
Friendly ping.
6 years, 8 months ago (2014-04-25 08:56:19 UTC) #4
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-04-30 11:20:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/239993004/1
6 years, 7 months ago (2014-04-30 11:21:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 11:25:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 11:25:29 UTC) #8
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-04-30 11:37:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/239993004/20001
6 years, 7 months ago (2014-04-30 11:38:41 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 11:42:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 11:42:20 UTC) #12
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-05-05 14:14:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/239993004/40001
6 years, 7 months ago (2014-05-05 14:15:37 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 16:31:47 UTC) #15
Message was sent while issue was closed.
Change committed as 268191

Powered by Google App Engine
This is Rietveld 408576698