Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3371)

Unified Diff: chrome/browser/chromeos/file_system_provider/service.cc

Issue 239993002: [fsp] Create a RequestManager per a ProvidedFileSystem instance. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed and rebased. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/file_system_provider/service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_system_provider/service.cc
diff --git a/chrome/browser/chromeos/file_system_provider/service.cc b/chrome/browser/chromeos/file_system_provider/service.cc
index 5348b34712a5e165057dc6871014dd0cdd9fb4eb..3bc173c4e776bbee6a198cad349aba0812f2576d 100644
--- a/chrome/browser/chromeos/file_system_provider/service.cc
+++ b/chrome/browser/chromeos/file_system_provider/service.cc
@@ -23,16 +23,13 @@ namespace {
// Maximum number of file systems to be mounted in the same time, per profile.
const size_t kMaxFileSystems = 16;
-// Default factory for provided file systems. The |event_router| nor the
-// |request_manager| arguments must not be NULL.
+// Default factory for provided file systems. The |event_router| must not be
+// NULL.
ProvidedFileSystemInterface* CreateProvidedFileSystem(
extensions::EventRouter* event_router,
- RequestManager* request_manager,
const ProvidedFileSystemInfo& file_system_info) {
DCHECK(event_router);
- DCHECK(request_manager);
- return new ProvidedFileSystem(
- event_router, request_manager, file_system_info);
+ return new ProvidedFileSystem(event_router, file_system_info);
}
} // namespace
@@ -41,9 +38,7 @@ Service::Service(Profile* profile)
: profile_(profile),
file_system_factory_(base::Bind(CreateProvidedFileSystem)),
next_id_(1),
- weak_ptr_factory_(this) {
- AddObserver(&request_manager_);
-}
+ weak_ptr_factory_(this) {}
Service::~Service() { STLDeleteValues(&file_system_map_); }
@@ -121,8 +116,8 @@ int Service::MountFileSystem(const std::string& extension_id,
extensions::EventRouter* event_router =
extensions::ExtensionSystem::Get(profile_)->event_router();
- ProvidedFileSystemInterface* file_system = file_system_factory_.Run(
- event_router, &request_manager_, file_system_info);
+ ProvidedFileSystemInterface* file_system =
+ file_system_factory_.Run(event_router, file_system_info);
DCHECK(file_system);
file_system_map_[file_system_id] = file_system;
@@ -223,7 +218,7 @@ ProvidedFileSystemInterface* Service::GetProvidedFileSystem(
return file_system_it->second;
}
-void Service::Shutdown() { RemoveObserver(&request_manager_); }
+void Service::Shutdown() {}
void Service::OnRequestUnmountStatus(
const ProvidedFileSystemInfo& file_system_info,
« no previous file with comments | « chrome/browser/chromeos/file_system_provider/service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698