Add LevelDB database names to tracing path for easier debugging

Add LevelDB database names to tracing path for easier debugging

The data from field trials show large databases, but not sure what are
their names. So, adding names to the path.

BUG=645126
Committed: https://crrev.com/279f8d702e8b2fffda1b7f50b311c5202331e121
Cr-Commit-Position: refs/heads/master@{#424055}

[ssid, 2016-10-06 23:42:34]

ssid@chromium.org changed reviewers:
+ primiano@chromium.org

[ssid, 2016-10-06 23:42:34]

primiano, wdyt?

[Primiano Tucci (use gerrit), 2016-10-07 02:25:56]

LGTM

https://codereview.chromium.org/2399903004/diff/1/components/leveldb_proto/le...
File components/leveldb_proto/leveldb_database.cc (right):

https://codereview.chromium.org/2399903004/diff/1/components/leveldb_proto/le...
components/leveldb_proto/leveldb_database.cc:192: dump_name += "/" +
client_name_;
can this have weird chars or /, or is it just fixed names coming from somewhere?
(if that's the case fine, no need to add checks)

[ssid, 2016-10-07 19:02:23]

https://codereview.chromium.org/2399903004/diff/1/components/leveldb_proto/le...
File components/leveldb_proto/leveldb_database.cc (right):

https://codereview.chromium.org/2399903004/diff/1/components/leveldb_proto/le...
components/leveldb_proto/leveldb_database.cc:192: dump_name += "/" +
client_name_;
On 2016/10/07 02:25:56, Primiano Tucci - slow til 10th wrote:
> can this have weird chars or /, or is it just fixed names coming from
somewhere?
> (if that's the case fine, no need to add checks)

All these strings are static strings defined as names. so, they don't have
special symbols. I am hoping that the whitelisting test will break if any new
names come up.

[ssid, 2016-10-07 19:03:38]

Patchset #2 (id:20001) has been deleted

[ssid, 2016-10-07 19:04:17]

ssid@chromium.org changed reviewers:
+ nyquist@chromium.org

[ssid, 2016-10-07 19:04:17]

+nyquist ptal, small change, Thanks!

[ssid, 2016-10-07 21:13:45]

ssid@chromium.org changed reviewers:
+ mathp@chromium.org

[ssid, 2016-10-07 21:13:46]

+mathp since Tommy is ooo. its a small change, ptal, thanks

[nyquist, 2016-10-07 23:34:41]

lgtm

[ssid, 2016-10-08 02:23:22]

The CQ bit was checked by ssid@chromium.org

[ssid, 2016-10-08 02:23:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2399903004/#ps40001
(title: "Add missing databases.")

[commit-bot: I haz the power, 2016-10-08 02:23:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 03:18:25]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-08 03:22:17]

Description was changed from

==========
Add LevelDB database names to tracing path for easier debugging

The data from field trials show large databases, but not sure what are
their names. So, adding names to the path.

BUG=645126
==========

to

==========
Add LevelDB database names to tracing path for easier debugging

The data from field trials show large databases, but not sure what are
their names. So, adding names to the path.

BUG=645126

Committed: https://crrev.com/279f8d702e8b2fffda1b7f50b311c5202331e121
Cr-Commit-Position: refs/heads/master@{#424055}
==========

[commit-bot: I haz the power, 2016-10-08 03:22:19]

Patchset 2 (id:??) landed as
https://crrev.com/279f8d702e8b2fffda1b7f50b311c5202331e121
Cr-Commit-Position: refs/heads/master@{#424055}

[ssid, 2016-12-29 02:20:22]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2601233002/ by ssid@chromium.org.

The reason for reverting is: We identified the largest consumer of memory in
leveldb_proto databases and fixed it crbug.com/662019.
It is not safe to add dumps with database names since new clients of
leveldb_proto might not update the whitelist and we will miss the memory usage..