Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2399883005: DevTools: CPU throttling should disable when DevTools are closed. (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: CPU throttling should disable when DevTools are closed. BUG=654138 Committed: https://crrev.com/94eb2d6a00a578b21a22f5c8cc9e5661d29b2a9e Cr-Commit-Position: refs/heads/master@{#424042}

Patch Set 1 #

Total comments: 2

Patch Set 2 : 4 landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
alph
4 years, 2 months ago (2016-10-08 00:34:16 UTC) #2
alph
4 years, 2 months ago (2016-10-08 00:34:18 UTC) #3
dgozman
lgtm https://codereview.chromium.org/2399883005/diff/1/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp File third_party/WebKit/Source/web/InspectorEmulationAgent.cpp (right): https://codereview.chromium.org/2399883005/diff/1/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp#newcode81 third_party/WebKit/Source/web/InspectorEmulationAgent.cpp:81: setCPUThrottlingRate(&error, 1.); I believe blink uses "1" in ...
4 years, 2 months ago (2016-10-08 00:37:36 UTC) #4
alph
https://codereview.chromium.org/2399883005/diff/1/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp File third_party/WebKit/Source/web/InspectorEmulationAgent.cpp (right): https://codereview.chromium.org/2399883005/diff/1/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp#newcode81 third_party/WebKit/Source/web/InspectorEmulationAgent.cpp:81: setCPUThrottlingRate(&error, 1.); On 2016/10/08 00:37:36, dgozman wrote: > I ...
4 years, 2 months ago (2016-10-08 00:40:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399883005/20001
4 years, 2 months ago (2016-10-08 00:41:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-08 02:00:21 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 02:02:03 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/94eb2d6a00a578b21a22f5c8cc9e5661d29b2a9e
Cr-Commit-Position: refs/heads/master@{#424042}

Powered by Google App Engine
This is Rietveld 408576698