Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2399883003: Add MB config and installer target for an official CrOS builder. (Closed)

Created:
4 years, 2 months ago by Dirk Pranke
Modified:
4 years, 2 months ago
Reviewers:
dnj, brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add MB config and installer target for an official CrOS builder. This adds an MB config for 'Linux ChromeOS Buildspec Tests' builder, and makes the 'linux_packages_all' target be defined for CrOS builds as well as desktop Linux, though I have no idea if this'll actually build in that config. TBR=dnj@chromium.org, brettw@chromium.org BUG=643238 Committed: https://crrev.com/b0a20f37160c224e1a27f92d859879f56a500eda Cr-Commit-Position: refs/heads/master@{#423739}

Patch Set 1 #

Patch Set 2 : make the installer be defined on CrOS builds as well as desktop Linux builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/installer/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/mb/mb_config.pyl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399883003/20001
4 years, 2 months ago (2016-10-06 21:06:52 UTC) #4
Dirk Pranke
4 years, 2 months ago (2016-10-06 21:06:59 UTC) #5
brettw
lgtm
4 years, 2 months ago (2016-10-06 21:15:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 23:41:16 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 23:43:19 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0a20f37160c224e1a27f92d859879f56a500eda
Cr-Commit-Position: refs/heads/master@{#423739}

Powered by Google App Engine
This is Rietveld 408576698