Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2399873003: Subzero: Fix "make -f Makefile.standalone check-lit FORCEASM=1". (Closed)

Created:
4 years, 2 months ago by Jim Stichnoth
Modified:
4 years, 2 months ago
Reviewers:
John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix "make -f Makefile.standalone check-lit FORCEASM=1". https://codereview.chromium.org/2384983002/ apparently didn't test the full "make presubmit", otherwise this would have been caught. BUG= none TBR=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=533a514f4d045a6cd9d2dd9fccb54f86094e6ef3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests_lit/llvm2ice_tests/unreachable.ll View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Jim Stichnoth
4 years, 2 months ago (2016-10-06 21:24:26 UTC) #4
Jim Stichnoth
Committed patchset #1 (id:1) manually as 533a514f4d045a6cd9d2dd9fccb54f86094e6ef3 (presubmit successful).
4 years, 2 months ago (2016-10-06 21:24:41 UTC) #6
John
4 years, 2 months ago (2016-10-06 21:30:43 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698