ui/views/controls/textfield/textfield.cc - Issue 2399863002: views: call UpdateAfterChange() in Textfield::InsertOrReplaceText().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 2399863002: views: call UpdateAfterChange() in Textfield::InsertOrReplaceText(). (Closed)

Patch Set: use TextfieldTestApi Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/textfield/textfield.cc

diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc

index 56ae56b8dd9d7be85ec284cd0eb4e95767f20934..3698349384b3edefab6b489d243948e3bad2efa8 100644

--- a/ui/views/controls/textfield/textfield.cc

+++ b/ui/views/controls/textfield/textfield.cc

@@ -324,8 +324,7 @@ void Textfield::InsertOrReplaceText(const base::string16& new_text) {

if (new_text.empty())

return;

model_->InsertText(new_text);

- OnCaretBoundsChanged();

- SchedulePaint();

+ UpdateAfterChange(true, true);

}

base::string16 Textfield::GetSelectedText() const {