views: call UpdateAfterChange() in Textfield::InsertOrReplaceText().

ui/views/controls/textfield/textfield.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #define UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 71 matching lines @@
   // Sets the text currently displayed in the Textfield.  This doesn't
   // change the cursor position if the current cursor is within the
   // new text's range, or moves the cursor to the end if the cursor is
   // out of the new text's range.
   void SetText(const base::string16& new_text);
 
   // Appends the given string to the previously-existing text in the field.
   void AppendText(const base::string16& new_text);
 
   // Inserts |new_text| at the cursor position, replacing any selected text.
+  // This method is used to handle user input via paths Textfield doesn't
+  // normally handle, so it calls UpdateAfterChange() and notifies observers of
+  // changes.
   void InsertOrReplaceText(const base::string16& new_text);
 
   // Returns the text that is currently selected. Call sites should take care to
   // not reveal the text for a password textfield.
   base::string16 GetSelectedText() const;
 
   // Select the entire text range. If |reversed| is true, the range will end at
   // the logical beginning of the text; this generally shows the leading portion
   // of text that overflows its display area.
   void SelectAll(bool reversed);
@@ skipping 220 matching lines @@
   gfx::Point last_click_location() const { return last_click_location_; }
 
   // Get the text from the selection clipboard.
   virtual base::string16 GetSelectionClipboardText() const;
 
   // Executes the given |command|.
   virtual void ExecuteTextEditCommand(ui::TextEditCommand command);
 
  private:
   friend class TextfieldTestApi;
+  FRIEND_TEST_ALL_PREFIXES(TextfieldTest, CursorBlinkRestartsOnInsertOrReplace);

[msw, 2016/10/07 17:16:38]

Please plumb the call through TextfieldTestApi instead of making this test
fixture a friend of the class.

[Elly Fong-Jones, 2016/10/07 17:25:57]

Done.

 
   // View overrides:
   // Declared final since overriding by subclasses would interfere with the
   // accounting related to the scheduled text edit command. Subclasses should
   // use TextfieldController::HandleKeyEvent, to intercept the key event.
   bool OnKeyPressed(const ui::KeyEvent& event) final;
   bool OnKeyReleased(const ui::KeyEvent& event) final;
 
   // Handles a request to change the value of this text field from software
   // using an accessibility API (typically automation software, screen readers
@@ skipping 176 matching lines @@
 
   // Used to bind callback functions to this object.
   base::WeakPtrFactory<Textfield> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Textfield);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_