views: call UpdateAfterChange() in Textfield::InsertOrReplaceText().

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include <set>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 371 matching lines @@
 void OmniboxViewViews::OnPaste() {
   const base::string16 text(GetClipboardText());
   if (!text.empty()) {
     OnBeforePossibleChange();
     // Record this paste, so we can do different behavior.
     model()->OnPaste();
     // Force a Paste operation to trigger the text_changed code in
     // OnAfterPossibleChange(), even if identical contents are pasted.
     state_before_change_.text.clear();
     InsertOrReplaceText(text);
+    // Since InsertOrReplaceText() is used for programmatically updating state,

[msw, 2016/10/07 01:47:52]

Textfield::InsertOrReplaceText is *only* called here. Can that just call
UpdateAfterChange internally? If you do that, feel free to update its function
comment wrt programmatic vs. interactive text changes, etc.

+    // it won't update cursor state, but since OnPaste() is actually triggered
+    // by a user action, the cursor does need to be updated.
+    UpdateAfterChange(true, true);
     OnAfterPossibleChange(true);
   }
 }
 
 bool OmniboxViewViews::HandleEarlyTabActions(const ui::KeyEvent& event) {
   // This must run before accelerator handling invokes a focus change on tab.
   // Note the parallel with SkipDefaultKeyEventProcessing above.
   if (!views::FocusManager::IsTabTraversalKeyEvent(event))
     return false;
 
@@ skipping 674 matching lines @@
       paste_position + 1, IDS_PASTE_AND_GO, IDS_PASTE_AND_GO);
 
   menu_contents->AddSeparator(ui::NORMAL_SEPARATOR);
 
   // Minor note: We use IDC_ for command id here while the underlying textfield
   // is using IDS_ for all its command ids. This is because views cannot depend
   // on IDC_ for now.
   menu_contents->AddItemWithStringId(IDC_EDIT_SEARCH_ENGINES,
       IDS_EDIT_SEARCH_ENGINES);
 }