Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2399853002: [parser] Lazy compilation no longer needs context chain. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Lazy compilation no longer needs context chain. Now that the scope chain is deserialized directly from the chain of {ScopeInfo} objects, it is no longer needed to provide a context. This makes the {AllowsLazyCompilationWithoutContext} predicate coincide with the more general {AllowsLazyCompilation}. Remove the former. R=jochen@chromium.org Committed: https://crrev.com/8f5d1c1d4c652f020352af8505baa29804a3ef3d Cr-Commit-Position: refs/heads/master@{#40042}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M src/ast/ast.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/ast.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ast/scopes.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 13 (6 generated)
Michael Starzinger
4 years, 2 months ago (2016-10-06 13:34:51 UTC) #5
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2399853002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/2399853002/diff/1/src/objects.cc#newcode13754 src/objects.cc:13754: shared_info->set_allows_lazy_compilation_without_context( why not remove allows_lazy_compilation_without_context from SFI?
4 years, 2 months ago (2016-10-06 13:58:48 UTC) #6
Michael Starzinger
https://codereview.chromium.org/2399853002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/2399853002/diff/1/src/objects.cc#newcode13754 src/objects.cc:13754: shared_info->set_allows_lazy_compilation_without_context( On 2016/10/06 13:58:48, jochen wrote: > why not ...
4 years, 2 months ago (2016-10-06 14:03:28 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-06 14:04:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399853002/1
4 years, 2 months ago (2016-10-06 14:15:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 14:17:55 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 14:18:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f5d1c1d4c652f020352af8505baa29804a3ef3d
Cr-Commit-Position: refs/heads/master@{#40042}

Powered by Google App Engine
This is Rietveld 408576698