Source/core/dom/Element.cpp - Issue 239983004: Textarea resize-able only to larger; min-height and min-width properly set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 239983004: Textarea resize-able only to larger; min-height and min-width properly set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing the changes asked in patch set 4 Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/textarea-resize-below-min-size-set.html ('K') | « Source/core/dom/Element.h ('k') | Source/core/dom/ElementRareData.h » ('j') | Source/core/rendering/RenderLayerScrollableArea.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 943459796b164060b9f801ac09003f4a163cf835..a4dbf6f90bc6cbfffe6f12a26d0ed13b059754ca 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -2382,18 +2382,6 @@ bool Element::isInDescendantTreeOf(const Element* shadowHost) const

return false;

}

-LayoutSize Element::minimumSizeForResizing() const

- return hasRareData() ? elementRareData()->minimumSizeForResizing() : defaultMinimumSizeForResizing();

-void Element::setMinimumSizeForResizing(const LayoutSize& size)

- if (!hasRareData() && size == defaultMinimumSizeForResizing())

- return;

- ensureElementRareData().setMinimumSizeForResizing(size);

RenderStyle* Element::computedStyle(PseudoId pseudoElementSpecifier)

{

if (PseudoElement* element = pseudoElement(pseudoElementSpecifier))