Source/core/rendering/RenderLayerScrollableArea.h - Issue 239983004: Textarea resize-able only to larger; min-height and min-width properly set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayerScrollableArea.h

Issue 239983004: Textarea resize-able only to larger; min-height and min-width properly set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addresses the changes asked in patch set 3 Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/textarea-resize-below-min-size-set.html ('K') | « Source/core/dom/ElementRareData.cpp ('k') | Source/core/rendering/RenderLayerScrollableArea.cpp » ('j') | Source/core/rendering/RenderLayerScrollableArea.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderLayerScrollableArea.h

diff --git a/Source/core/rendering/RenderLayerScrollableArea.h b/Source/core/rendering/RenderLayerScrollableArea.h

index af9cf329628f41edbb5f44afd2b7a4a36c49929f..0b4e4e87fd1606522919653f2d2cadddd8cc6550 100644

--- a/Source/core/rendering/RenderLayerScrollableArea.h

+++ b/Source/core/rendering/RenderLayerScrollableArea.h

@@ -209,6 +209,7 @@ private:

void setHasVerticalScrollbar(bool hasScrollbar);

void updateScrollCornerStyle();

+ void updateMinimumSizeForResizing();

// See comments on isPointInResizeControl.

IntRect resizerCornerRect(const IntRect&, ResizerHitTestType) const;

@@ -246,6 +247,9 @@ private:

// This is the (scroll) offset from scrollOrigin().

IntSize m_scrollOffset;

+ // This is the minimum size for resizing.

+ LayoutSize m_minimumSizeForResizing;

IntPoint m_cachedOverlayScrollbarOffset;

// For areas with overflow, we have a pair of scrollbars.