Textarea resize-able only to larger; min-height and min-width properly set

Source/core/rendering/RenderLayerScrollableArea.cpp

Index: Source/core/rendering/RenderLayerScrollableArea.cpp
diff --git a/Source/core/rendering/RenderLayerScrollableArea.cpp b/Source/core/rendering/RenderLayerScrollableArea.cpp
index a93e4f9d94866456285f0f7d108eb5fc933b4b53..82dee2da859cd3c796af765ef6d7b8f346aa3c57 100644
--- a/Source/core/rendering/RenderLayerScrollableArea.cpp
+++ b/Source/core/rendering/RenderLayerScrollableArea.cpp
@@ -94,6 +94,7 @@ RenderLayerScrollableArea::RenderLayerScrollableArea(RenderBox* box)
         if (!m_scrollOffset.isZero())
             scrollAnimator()->setCurrentPosition(FloatPoint(m_scrollOffset.width(), m_scrollOffset.height()));
         element->setSavedLayerScrollOffset(IntSize());
+        element->setMinimumSizeForResizing(LayoutSize(LayoutUnit(m_box->style()->logicalMinWidth().value()), LayoutUnit(m_box->style()->logicalMinHeight().value())));

[Julien - ping for review, 2014/04/18 17:04:08]

This is wrong for several reasons:
1. it's not dynamic, which means that if you update min-width / min-height, you
won't update your limit and that seems wrong to me.
2. more importantly this will convert min-width: 50% into min-width: 50px which
is is just wrong.

To solve them:
1. You need to put the logic into updateAfterStyleChange.
2. You don't convert a Length into a LayoutUnit by calling Length.value(),
that's because some Length need some computations to be converted into absolute
pixels. That's handled by valueForLength().

[harpreet.sk, 2014/04/21 13:21:55]

 I have added the logic into updateAfterStyleChange. Now using valueForLength()
for converting Length to LayoutUnit. As per esprehn comment i also added check
to see if min-height or min-width is 0 or not. If it is 0 i had set the
min-value to 15px. I set it to 15px as Firefox also set it to 15px.

     }
 
     updateResizerAreaSet();
@@ -1336,8 +1337,7 @@ void RenderLayerScrollableArea::resize(const PlatformEvent& evt, const LayoutSiz
     newOffset.setHeight(newOffset.height() / zoomFactor);
 
     LayoutSize currentSize = LayoutSize(m_box->width() / zoomFactor, m_box->height() / zoomFactor);
-    LayoutSize minimumSize = element->minimumSizeForResizing().shrunkTo(currentSize);
-    element->setMinimumSizeForResizing(minimumSize);
+    LayoutSize minimumSize = element->minimumSizeForResizing();
 
     LayoutSize adjustedOldOffset = LayoutSize(oldOffset.width() / zoomFactor, oldOffset.height() / zoomFactor);
     if (m_box->style()->shouldPlaceBlockDirectionScrollbarOnLogicalLeft()) {