LayoutTests/fast/forms/textarea-resize-min-width-min-height.html - Issue 239983004: Textarea resize-able only to larger; min-height and min-width properly set

Side by Side Diff: LayoutTests/fast/forms/textarea-resize-min-width-min-height.html

Issue 239983004: Textarea resize-able only to larger; min-height and min-width properly set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing the changes asked in comments in patch set 1 Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"

	2 "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
	Julien - ping for review 2014/04/21 17:46:46 We prefer to use the HTML5 doctype (easier to read We prefer to use the HTML5 doctype (easier to read): <!DOCTYPE html> harpreet.sk 2014/04/24 15:28:27 Changed to HTML5 doctype. Show quoted text On 2014/04/21 17:46:46, Julien Chaffraix - PST wrote: > We prefer to use the HTML5 doctype (easier to read): > > <!DOCTYPE html> Changed to HTML5 doctype.
	3 <html>

	4 <head>

	5 <script>

	6 function log(msg)

	7 {

	8 document.getElementById('console').appendChild(document.createTextNode(msg + '\n'));

	9 }

	10

	11 function updateSize()
	Julien - ping for review 2014/04/21 17:46:46 I am not a huge fan of bundling several tests into I am not a huge fan of bundling several tests into one. This is because your test is now fragile (can break for several reasons) and unfocused (more difficult to maintain / follow). Also this test has the following shortcomings: - you don't test the 15x15 minimum. - you don't test other values for <length> (<percentage> is only one of the possibility that would have been broken, viewport relative length would have been as broken, harpreet.sk 2014/04/24 15:28:27 This layout test is removed and 3 new layout test Show quoted text On 2014/04/21 17:46:46, Julien Chaffraix - PST wrote: > I am not a huge fan of bundling several tests into one. This is because your > test is now fragile (can break for several reasons) and unfocused (more > difficult to maintain / follow). > > Also this test has the following shortcomings: > - you don't test the 15x15 minimum. > - you don't test other values for <length> (<percentage> is only one of the > possibility that would have been broken, viewport relative length would have > been as broken, This layout test is removed and 3 new layout test added with different test cases as given below: Case 1: Test for resizing below intrinsic minmum size ( 15x15 case ) Case 2: Test for resizing below minimum size set by user. Case 3 Test for resizing above minimum size set by user and below initial size. Each layout test also checks for following types of length: 1. Length of fixed type (px) 2. Length of percentage type (%) 3. Length in terms of viewport-length (vw or vh)
	12 {

	13 var textAreaElement = document.getElementById("textInputID");

	14 textAreaElement.style.minWidth="10%";

	15 textAreaElement.style.minHeight="10%";

	16 test();

	17 }

	18

	19 function test()

	20 {

	21 if (window.testRunner) {

	22 testRunner.waitUntilDone();
	Julien - ping for review 2014/04/21 17:46:46 You don't need to make the test asynchronous as we You don't need to make the test asynchronous as we wait until the end of the 'load' listener to stop the test and dump the result. harpreet.sk 2014/04/24 15:28:27 Done. Show quoted text On 2014/04/21 17:46:46, Julien Chaffraix - PST wrote: > You don't need to make the test asynchronous as we wait until the end of the > 'load' listener to stop the test and dump the result. Done.
	23 testRunner.dumpAsText();

	24 testDragAndMove();

	25 } else

	26 log("testRunner is not available");
	Julien - ping for review 2014/04/21 17:46:46 That's not an helpful and actionable message. Some That's not an helpful and actionable message. Somebody opening the test wouldn't understand what this means. Here is a better message: log("This test needs to window.testRunner and window.eventSender to work. To manually test it, drag the text area above, it shouldn't go below the min-width and min-height."); harpreet.sk 2014/04/24 15:28:27 Action message is modified. Show quoted text On 2014/04/21 17:46:46, Julien Chaffraix - PST wrote: > That's not an helpful and actionable message. Somebody opening the test wouldn't > understand what this means. > > Here is a better message: > log("This test needs to window.testRunner and window.eventSender to work. To > manually test it, drag the text area above, it shouldn't go below the min-width > and min-height."); Action message is modified.
	27 }

	28

	29 function testDragAndMove()

	30 {

	31 var draggable = document.getElementById("textInputID");

	32 var startX = draggable.offsetLeft + 400;

	33 var startY = draggable.offsetTop + 400;

	34

	35 log("TextArea initial width is " + draggable.style.width);

	36 log("TextArea initial height is " + draggable.style.height);

	37 log("Dragging textarea to reduce it's width by 250px and height by 340px");

	38

	39 eventSender.dragMode = false;

	40 eventSender.mouseMoveTo(startX,startY);

	41 eventSender.mouseDown();

	42 // Then drag it. OK not to crash.

	43 eventSender.mouseMoveTo(startX - 250, startY - 340);

	44 //eventSender.mouseMoveTo(startX + 20, startY + 20);

	45 eventSender.mouseUp();

	46

	47 log("After dragging textarea new width is " + draggable.style.width);

	48 log("After dragging textarea new height is " + draggable.style.height);

	49 log("You will see a PASS message below if new width is 150px and new height is 60px");

	50

	51 if ((draggable.style.width == "150px") && (draggable.style.height == "60px") )

	52 log("PASS");

	53

	54 testRunner.notifyDone();

	55 }

	56 </script>

	57 </head>

	58 <body onload="updateSize()">

	59 <textarea style="width:400px; height:400px; min-width:200px; min-height:200px" i d="textInputID">

	60 Some text

	61 </textarea>

	62 <pre id="console"></pre>

	63 </body>

	64 </html>

OLD	NEW