Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 2399813002: Return null when window.open blocks a popup. (Closed)

Created:
4 years, 2 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return null when window.open blocks a popup. window.open [1] steps 4 and 9.1 say to return null, not undefined, when window.open decides to not open a window. This brings Chrome into line with Edge and Firefox. [1] https://html.spec.whatwg.org/#dom-open BUG=652640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/history/window-open-blocked.html View 1 chunk +10 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/history/window-open-blocked-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (4 generated)
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-06 07:32:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399813002/1
4 years, 2 months ago (2016-10-06 07:32:42 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-06 08:00:24 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 08:00:25 UTC) #4
Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

Powered by Google App Engine
This is Rietveld 408576698