Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2399803002: Remove TODO about normalizing calc() values at parse time for registered properties (Closed)

Created:
4 years, 2 months ago by Timothy Loh
Modified:
4 years, 2 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TODO about normalizing calc() values at parse time for registered properties This patch removes a TODO which states we should normalize calc() values when parsing them for registered properties. I don't recall exactly why I added this TODO but it doesn't seem that the spec says this needs to be done. We already simplify calc() values in computation as per spec. https://drafts.css-houdini.org/css-properties-values-api/ BUG=641877 Committed: https://crrev.com/483abaf5253f6e4864914f7824142995a51d8254 Cr-Commit-Position: refs/heads/master@{#423778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Timothy Loh
4 years, 2 months ago (2016-10-06 07:30:52 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 2 months ago (2016-10-07 00:06:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399803002/1
4 years, 2 months ago (2016-10-07 00:44:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 02:04:29 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 02:07:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/483abaf5253f6e4864914f7824142995a51d8254
Cr-Commit-Position: refs/heads/master@{#423778}

Powered by Google App Engine
This is Rietveld 408576698