DescriptionRevert of MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget. (patchset #1 id:20001 of https://codereview.chromium.org/2396883004/ )
Reason for revert:
Breaks compile. Probably because the CountBridgedWindows function is only compiled in when DCHECK are ON.
Original issue's description:
> MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.
>
> BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
> ensure that
> - When a window is hidden, all its child windows are hidden and removed from its
> child window list.
> - When a window is made visible, all its child windows which want to become
> visible are made visible and added to its child window list.
>
> However, this does not account for windows which may be added by AppKit, for
> example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
> account for windows added by AppKit.
>
> BUG=653325
>
> Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
> Cr-Commit-Position: refs/heads/master@{#423450}
TBR=tapted@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=653325
Committed: https://crrev.com/0e73c3942b2b2b8a623a7c42dd32bc6fabd86ceb
Cr-Commit-Position: refs/heads/master@{#423453}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|