Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2399783002: Revert of MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget. (Closed)

Created:
4 years, 2 months ago by karandeepb
Modified:
4 years, 2 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget. (patchset #1 id:20001 of https://codereview.chromium.org/2396883004/ ) Reason for revert: Breaks compile. Probably because the CountBridgedWindows function is only compiled in when DCHECK are ON. Original issue's description: > MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget. > > BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to > ensure that > - When a window is hidden, all its child windows are hidden and removed from its > child window list. > - When a window is made visible, all its child windows which want to become > visible are made visible and added to its child window list. > > However, this does not account for windows which may be added by AppKit, for > example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly > account for windows added by AppKit. > > BUG=653325 > > Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021 > Cr-Commit-Position: refs/heads/master@{#423450} TBR=tapted@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653325 Committed: https://crrev.com/0e73c3942b2b2b8a623a7c42dd32bc6fabd86ceb Cr-Commit-Position: refs/heads/master@{#423453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -24 lines) Patch
M ui/views/cocoa/bridged_native_widget.mm View 3 chunks +8 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
karandeepb
Created Revert of MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.
4 years, 2 months ago (2016-10-06 06:38:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399783002/1
4 years, 2 months ago (2016-10-06 06:38:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 06:39:06 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 06:40:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e73c3942b2b2b8a623a7c42dd32bc6fabd86ceb
Cr-Commit-Position: refs/heads/master@{#423453}

Powered by Google App Engine
This is Rietveld 408576698