Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2399773002: Prune deprecated functions from BreakBlockquoteCommand (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune deprecated functions from BreakBlockquoteCommand BUG=647219, 651373 Committed: https://crrev.com/00789267c5d338a9d2151c950fbd8bf9f47ba92b Cr-Commit-Position: refs/heads/master@{#423534}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp View 1 6 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-06 09:31:01 UTC) #8
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-06 09:38:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399773002/10002
4 years, 2 months ago (2016-10-06 14:57:31 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:10002)
4 years, 2 months ago (2016-10-06 15:04:35 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 15:07:31 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00789267c5d338a9d2151c950fbd8bf9f47ba92b
Cr-Commit-Position: refs/heads/master@{#423534}

Powered by Google App Engine
This is Rietveld 408576698