Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2399753002: Prune createVisibleSelectionDeprecated from Element (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index 3651e0f9360dbcf1107fd9c0d3151151bab1068e..864415b91be3f68c78bbd16c5d7fbaca3915a954 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -2633,8 +2633,12 @@ void Element::updateFocusAppearance(
if (this == frame->selection().rootEditableElement())
return;
+ // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+ // needs to be audited. See http://crbug.com/590369 for more details.
+ document().updateStyleAndLayoutIgnorePendingStylesheets();
+
// FIXME: We should restore the previous selection if there is one.
- VisibleSelection newSelection = createVisibleSelectionDeprecated(
+ VisibleSelection newSelection = createVisibleSelection(
firstPositionInOrBeforeNode(this), TextAffinity::Downstream);
// Passing DoNotSetFocus as this function is called after
// FocusController::setFocusedElement() and we don't want to change the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698