Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2399753002: Prune createVisibleSelectionDeprecated from Element (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisibleSelectionDeprecated from Element BUG=651373 Committed: https://crrev.com/8766a6a54ee2092471d862112da82e958a18aa9d Cr-Commit-Position: refs/heads/master@{#423432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-06 03:48:18 UTC) #4
tkent
lgtm
4 years, 2 months ago (2016-10-06 04:02:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399753002/1
4 years, 2 months ago (2016-10-06 04:37:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 04:43:18 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 04:45:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8766a6a54ee2092471d862112da82e958a18aa9d
Cr-Commit-Position: refs/heads/master@{#423432}

Powered by Google App Engine
This is Rietveld 408576698