Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 239973005: Remove GPU_FEATURE_TYPE_3D_CSS and --disable-accelerated-layers (Closed)

Created:
6 years, 8 months ago by piman
Modified:
6 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove GPU_FEATURE_TYPE_3D_CSS and --disable-accelerated-layers We ignore GPU_FEATURE_TYPE_3D_CSS, so remove it. Nothing sets --disable-accelerated-layers, and it doesn't correspond to a production path, so remove it. This lets us clean up some WebPreferences fields which are always set to true. Also remove WebPreferences::accelerated_compositing_for_plugins_enabled which is always true. BUG=362164, 365847 R=bbudge@chromium.org, danakj@chromium.org, tsepez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266226

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix tests #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -72 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 3 chunks +2 lines, -24 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/resources/gpu/info_view.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/web_preferences.cc View 1 2 3 1 chunk +5 lines, -8 lines 0 comments Download
M content/test/gpu/gpu_tests/hardware_accelerated_feature.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_blacklist.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/config/gpu_blacklist_unittest.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/config/gpu_feature_type.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppapi_preferences.cc View 1 chunk +1 line, -5 lines 0 comments Download
M webkit/common/webpreferences.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/common/webpreferences.cc View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 30 (0 generated)
piman
danakj: please review darin: webkit/ OWNER bbudge: ppapi/ OWNER tsepez: content/public/common/common_param_traits_macros.h security OWNER
6 years, 8 months ago (2014-04-16 23:00:30 UTC) #1
bbudge
ppapi LGTM Thanks for deleting this little mess.
6 years, 8 months ago (2014-04-16 23:17:44 UTC) #2
danakj
LGTM
6 years, 8 months ago (2014-04-16 23:40:24 UTC) #3
Tom Sepez
Rubberstamp LGTM on deleting members.
6 years, 8 months ago (2014-04-16 23:42:39 UTC) #4
danakj
Can we land?
6 years, 8 months ago (2014-04-22 21:58:05 UTC) #5
piman
On Tue, Apr 22, 2014 at 2:58 PM, <danakj@chromium.org> wrote: > Can we land? > ...
6 years, 8 months ago (2014-04-22 22:41:34 UTC) #6
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-23 01:32:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/239973005/20001
6 years, 8 months ago (2014-04-23 01:34:36 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 01:50:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-23 01:50:01 UTC) #10
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-23 02:40:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/239973005/40001
6 years, 8 months ago (2014-04-23 02:41:29 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 02:44:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 8 months ago (2014-04-23 02:44:34 UTC) #14
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-23 03:31:42 UTC) #15
piman
Oh, still waiting for OWNERS in webkit. darin: ping?
6 years, 8 months ago (2014-04-23 03:32:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/239973005/40001
6 years, 8 months ago (2014-04-23 03:32:39 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 03:49:06 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-23 03:49:07 UTC) #19
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 8 months ago (2014-04-24 19:36:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/239973005/40001
6 years, 8 months ago (2014-04-24 21:07:56 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 21:08:18 UTC) #22
commit-bot: I haz the power
Failed to apply patch for content/browser/gpu/gpu_data_manager_impl_private.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-24 21:08:19 UTC) #23
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-24 23:27:33 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/239973005/60001
6 years, 8 months ago (2014-04-24 23:27:57 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 00:31:11 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 00:31:12 UTC) #27
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-25 06:12:09 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/239973005/60001
6 years, 8 months ago (2014-04-25 08:22:03 UTC) #29
piman
6 years, 8 months ago (2014-04-25 20:02:28 UTC) #30
Message was sent while issue was closed.
Committed patchset #5 manually as r266226 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698