Issue 239973002: Add blink interface (and code) for setting navigator.serviceWorker.current

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239973002: Add blink interface (and code) for setting navigator.serviceWorker.current (Closed)

Created:
6 years, 8 months ago by kinuko

Modified:
6 years, 8 months ago

Reviewers:
falken, tkent, dominicc (has gone to gerrit)

CC:
blink-reviews, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, kinuko, falken, dglazkov+blink, horo+watch_chromium.org, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add blink interface (and code) for setting navigator.serviceWorker.current BUG=361344 TEST=to be added when we have chromium code + binding code Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171753

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -8 lines)			Patch
M	Source/modules/serviceworkers/ServiceWorkerContainer.h	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	Source/modules/serviceworkers/ServiceWorkerContainer.cpp	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	public/platform/WebServiceWorkerProviderClient.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kinuko

Kent-san, another one... could you do owner review for public/ change? Thanks,

6 years, 8 months ago (2014-04-16 05:30:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/239973002/1

6 years, 8 months ago (2014-04-16 06:04:20 UTC) #5

Message was sent while issue was closed.

Change committed as 171753

Expand Messages | Collapse Messages