third_party/WebKit/LayoutTests/http/tests/security/sandboxed-opener-can-close-window.html - Issue 2399713002: window.close() should work from a sandboxed iframe if iframe is opener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/sandboxed-opener-can-close-window.html

Issue 2399713002: window.close() should work from a sandboxed iframe if iframe is opener (Closed)

Patch Set: +close() test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/security/sandboxed-opener-can-close-window-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/security/sandboxed-opener-can-close-window.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-when-allowed.html b/third_party/WebKit/LayoutTests/http/tests/security/sandboxed-opener-can-close-window.html

similarity index 52%

copy from third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-when-allowed.html

copy to third_party/WebKit/LayoutTests/http/tests/security/sandboxed-opener-can-close-window.html

index 26e581024bb74474144180ea9cd9b7b1807e4792..fa878452d628142073abacdf97e6b31677d16242 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-when-allowed.html

+++ b/third_party/WebKit/LayoutTests/http/tests/security/sandboxed-opener-can-close-window.html

@@ -1,16 +1,19 @@

if (window.testRunner) {

testRunner.dumpAsText();

- testRunner.waitUntilDone();

+ testRunner.dumpChildFramesAsText();

testRunner.setCanOpenWindows(true);

testRunner.setCloseRemainingWindowsWhenComplete(true);

}

</script>

<p>To run this test outside of DumpRenderTree, please disable your popup blocker!</p>

+<p>This test passes if it doesnt hang.</p>

src="data:text/html,

- <script>

- var win = window.open('data:text/html,<script>if (window.testRunner) testRunner.notifyDone();<\/script>', '_blank');

- console.log(win ? 'PASS' : 'FAIL');

- </script>"

+ <body><script>

+ var win = window.open('data:text/html,', '_blank');

+ win.close();

+ document.body.appendChild(

+ document.createTextNode(win.closed ? 'PASS' : 'FAIL'));

+ </script></body>"

></iframe>