Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html

Issue 2399713002: window.close() should work from a sandboxed iframe if iframe is opener (Closed)
Patch Set: +close() test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-when-allowed.html b/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html
similarity index 67%
copy from third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-when-allowed.html
copy to third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html
index 26e581024bb74474144180ea9cd9b7b1807e4792..7ffb936edb8f003702cae064c151263fa2c72b46 100644
--- a/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-when-allowed.html
+++ b/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html
@@ -7,10 +7,11 @@ if (window.testRunner) {
}
</script>
<p>To run this test outside of DumpRenderTree, please disable your popup blocker!</p>
+<p>This test passes if it doesnt hang.</p>
<iframe sandbox="allow-scripts allow-popups"
src="data:text/html,
<script>
- var win = window.open('data:text/html,<script>if (window.testRunner) testRunner.notifyDone();<\/script>', '_blank');
- console.log(win ? 'PASS' : 'FAIL');
+ var win = window.open('data:text/html,', '_blank');
+ win.location = 'http://127.0.0.1:8000/navigation/resources/pass-and-notify-done.html';
</script>"
></iframe>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698