Don't create PepperMessageFilter for renderer processes.

Don't create PepperMessageFilter for renderer processes.

PepperMessageFilter is used for PPB_NetworkMonitor and
PPB_X509Certificate. Neither of these APIs is supported for
in-process plugins.

TBR=sky@chromium.org, yzshen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221764

[yzshen1, 2013-09-05 22:42:49]

https://codereview.chromium.org/23997002/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/pepper/pepper_message_filter.cc (right):

https://codereview.chromium.org/23997002/diff/1/content/browser/renderer_host...
content/browser/renderer_host/pepper/pepper_message_filter.cc:34:
IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBX509Certificate_ParseDER,
It is still possible that this is sent from the renderer:
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/p...

I don't know who are using it. We could double check and maybe remove the
in-process support.

https://codereview.chromium.org/23997002/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/pepper/pepper_message_filter.h (right):

https://codereview.chromium.org/23997002/diff/1/content/browser/renderer_host...
content/browser/renderer_host/pepper/pepper_message_filter.h:26: // This class
is used in two contexts, both supporting PPAPI plugins. The first
Please update the comments.

[Sergey Ulanov, 2013-09-05 23:05:23]

https://codereview.chromium.org/23997002/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/pepper/pepper_message_filter.cc (right):

https://codereview.chromium.org/23997002/diff/1/content/browser/renderer_host...
content/browser/renderer_host/pepper/pepper_message_filter.cc:34:
IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBX509Certificate_ParseDER,
On 2013/09/05 22:42:49, yzshen1 wrote:
> It is still possible that this is sent from the renderer:
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/p...
> 
> I don't know who are using it. We could double check and maybe remove the
> in-process support.

Ah, yes, didn't notice it. As far as I can tell this interface was added for
Flash, and flash always runs out of process, so it's safe to remove this code.
WDYT?

[Sergey Ulanov, 2013-09-05 23:08:42]

https://codereview.chromium.org/23997002/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/pepper/pepper_message_filter.h (right):

https://codereview.chromium.org/23997002/diff/1/content/browser/renderer_host...
content/browser/renderer_host/pepper/pepper_message_filter.h:26: // This class
is used in two contexts, both supporting PPAPI plugins. The first
On 2013/09/05 22:42:49, yzshen1 wrote:
> Please update the comments.

Done.

[yzshen1, 2013-09-05 23:11:33]

lgtm

[sky, 2013-09-05 23:42:12]

What do you need me to review here?

[Sergey Ulanov, 2013-09-06 00:27:57]

On 2013/09/05 23:42:12, sky wrote:
> What do you need me to review here?

I need OWNERS approval for content/browser.

[sky, 2013-09-06 16:08:42]

content/browser/ppapi_plugin_process_host.cc and
content/browser/renderer_host/render_process_host_impl.cc LGTM

[commit-bot: I haz the power, 2013-09-06 18:36:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23997002/25001

[Sergey Ulanov, 2013-09-06 20:14:58]

Committed patchset #3 manually as r221764 (presubmit successful).