Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2399673002: Fix blob URL blocking for apps that use <webview>. (Closed)

Created:
4 years, 2 months ago by alexmos
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix blob URL blocking for apps that use <webview>. It should be possible for an app to embed a <webview> and navigate it to a blob URL that the app creates. In a previous security fix (r419019), this navigation was unintentionally blocked, due to <webview> being considered a main frame as well as being in an untrusted web process which is requesting a blob URL in a chrome-extension:// scheme. BUG=652077, 645028 Review-Url: https://codereview.chromium.org/2387323002 Cr-Commit-Position: refs/heads/master@{#422954} (cherry picked from commit cd20702d3b3dd5224beaa7fd7b876313b33b6b70) Committed: https://chromium.googlesource.com/chromium/src/+/01928f6ddee40f6e2e5041013c2773e515176955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_extensions_network_delegate.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
alexmos
4 years, 2 months ago (2016-10-05 21:40:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
01928f6ddee40f6e2e5041013c2773e515176955.

Powered by Google App Engine
This is Rietveld 408576698