third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp - Issue 2399663003: Reflow comments in //third_party/WebKit/Source/core/editing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Issue 2399663003: Reflow comments in //third_party/WebKit/Source/core/editing (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/InputMethodController.cpp ('k') | third_party/WebKit/Source/core/editing/PendingSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

index 099875ac5ad6cf4845837a9fd1fa87a20d964465..833bc94aadf236d12ab870395481fc1d0a14bea5 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

@@ -85,8 +85,8 @@ TEST_F(InputMethodControllerTest, BackspaceFromEndOfInput) {

controller().extendSelectionAndDelete(1, 0);

EXPECT_STREQ("foo", input->value().utf8().data());

- input->setValue(String::fromUTF8(

- "foo\xE0\xB8\x81\xE0\xB9\x89")); // composed U+0E01 "ka kai" + U+0E49 "mai tho"

+ // composed U+0E01 "ka kai" + U+0E49 "mai tho"

+ input->setValue(String::fromUTF8("foo\xE0\xB8\x81\xE0\xB9\x89"));

document().updateStyleAndLayout();

controller().setEditableSelectionOffsets(PlainTextRange(4, 4));

EXPECT_STREQ("foo\xE0\xB8\x81\xE0\xB9\x89", input->value().utf8().data());

@@ -261,7 +261,8 @@ TEST_F(InputMethodControllerTest, SetCompositionForInputWithNewCaretPositions) {

TEST_F(InputMethodControllerTest,

SetCompositionForContentEditableWithNewCaretPositions) {

- // There are 7 nodes and 5+1+5+1+3+4+3 characters: "hello", '\n', "world", "\n", "012", "3456", "789".

+ // There are 7 nodes and 5+1+5+1+3+4+3 characters: "hello", '\n', "world",

+ // "\n", "012", "3456", "789".

Element* div = insertHTMLElement(

"<div id='sample' contenteditable='true'>"

"hello"