Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2399663003: Reflow comments in //third_party/WebKit/Source/core/editing (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
Nico, yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in //third_party/WebKit/Source/core/editing BUG=563793 Committed: https://crrev.com/19588751197923c2c7604dd71c361713f9c1a07f Cr-Commit-Position: refs/heads/master@{#423490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -415 lines) Patch
M third_party/WebKit/Source/core/editing/CaretBase.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaretController.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingBehavior.h View 2 chunks +34 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingBehavior.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingBehaviorTypes.h View 1 chunk +12 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStrategy.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 31 chunks +92 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 4 chunks +18 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 14 chunks +47 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp View 11 chunks +26 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 14 chunks +40 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EphemeralRange.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FindOptions.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 6 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 17 chunks +46 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/GranularityStrategy.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp View 8 chunks +17 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 6 chunks +25 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PendingSelection.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PlainTextRange.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.h View 4 chunks +21 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionIterator.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionIterator.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/RenderedPosition.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 7 chunks +18 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionModifier.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionModifier.cpp View 10 chunks +37 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SurroundingText.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 5 chunks +27 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 19 chunks +50 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dcheng
Last one for core/editing =)
4 years, 2 months ago (2016-10-06 07:40:59 UTC) #4
yosin_UTC9
lgtm Thanks so much!
4 years, 2 months ago (2016-10-06 09:32:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399663003/1
4 years, 2 months ago (2016-10-06 09:32:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 09:41:33 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 09:43:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19588751197923c2c7604dd71c361713f9c1a07f
Cr-Commit-Position: refs/heads/master@{#423490}

Powered by Google App Engine
This is Rietveld 408576698