Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2399643002: Ship Referrer-Policy header (Closed)

Created:
4 years, 2 months ago by estark
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-worker-reviews_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, falken, gavinp+loader_chromium.org, horo+watch_chromium.org, Nate Chapin, kinuko+worker_chromium.org, loading-reviews_chromium.org, shimazu+worker_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship Referrer-Policy header Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/y4a1OWfMzN0/XFBIp_GIBgAJ BUG=619228 Committed: https://crrev.com/1c7f4eba31fca673ed6adbfd2f7e2f04394da590 Cr-Commit-Position: refs/heads/master@{#424236}

Patch Set 1 #

Patch Set 2 : fix unit test #

Patch Set 3 : remove some more missed ShouldEnableReferrerPolicyHeader() spots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -53 lines) Patch
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_url_request_context_getter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_url_request_context_getter.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M net/url_request/url_request_context.h View 2 chunks +0 lines, -13 lines 0 comments Download
M net/url_request/url_request_context.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M net/url_request/url_request_job_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (15 generated)
estark
jochen: can you please review //content and //third_party/WebKit? mmenke: can you please review //net?
4 years, 2 months ago (2016-10-10 17:41:09 UTC) #13
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-10 18:04:56 UTC) #14
mmenke
On 2016/10/10 18:04:56, jochen wrote: > lgtm net/ and profiles/ LGTM
4 years, 2 months ago (2016-10-10 18:30:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399643002/40001
4 years, 2 months ago (2016-10-10 19:13:09 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-10 21:07:31 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 21:10:02 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1c7f4eba31fca673ed6adbfd2f7e2f04394da590
Cr-Commit-Position: refs/heads/master@{#424236}

Powered by Google App Engine
This is Rietveld 408576698