Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2399633003: reflow comments in core/css/resolver (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, kenneth.christiansen, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, Eric Willigers, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in core/css/resolver BUG=563793 Committed: https://crrev.com/3c13b6e7f8eccc79baf7cdd1e05234119bab2b44 Cr-Commit-Position: refs/heads/master@{#423412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -253 lines) Patch
M third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h View 1 chunk +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ElementResolveContext.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ElementResolveContext.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FontBuilder.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MatchRequest.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MatchResult.h View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MatchResult.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MediaQueryResult.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp View 6 chunks +16 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 16 chunks +65 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 5 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 6 chunks +18 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 5 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 36 chunks +122 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverState.h View 4 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverState.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Nico
4 years, 2 months ago (2016-10-05 22:30:47 UTC) #4
Timothy Loh
On 2016/10/05 22:30:47, Nico wrote: stamp lgtm
4 years, 2 months ago (2016-10-06 02:18:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399633003/1
4 years, 2 months ago (2016-10-06 02:47:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 02:55:56 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 02:58:48 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3c13b6e7f8eccc79baf7cdd1e05234119bab2b44
Cr-Commit-Position: refs/heads/master@{#423412}

Powered by Google App Engine
This is Rietveld 408576698