content/public/browser/web_ui_data_source.h - Issue 2399553002: Gzip compress chrome://accessibility resources

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/browser/web_ui_data_source.h

Issue 2399553002: Gzip compress chrome://accessibility resources (Closed)

Patch Set: logging nits Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/content_resources.grd ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_UI_DATA_SOURCE_H_	5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_UI_DATA_SOURCE_H_

6 #define CONTENT_PUBLIC_BROWSER_WEB_UI_DATA_SOURCE_H_	6 #define CONTENT_PUBLIC_BROWSER_WEB_UI_DATA_SOURCE_H_

7	7

8 #include <stdint.h>	8 #include <stdint.h>

9	9

10 #include "base/callback.h"	10 #include "base/callback.h"

(...skipping 78 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
89 virtual void DisableContentSecurityPolicy() = 0;	89 virtual void DisableContentSecurityPolicy() = 0;

90 virtual void OverrideContentSecurityPolicyObjectSrc(	90 virtual void OverrideContentSecurityPolicyObjectSrc(

91 const std::string& data) = 0;	91 const std::string& data) = 0;

92 virtual void OverrideContentSecurityPolicyChildSrc(	92 virtual void OverrideContentSecurityPolicyChildSrc(

93 const std::string& data) = 0;	93 const std::string& data) = 0;

94 virtual void DisableDenyXFrameOptions() = 0;	94 virtual void DisableDenyXFrameOptions() = 0;

95	95

96 // Tells the loading code that resources are gzipped on disk. TODO(dbeam):	96 // Tells the loading code that resources are gzipped on disk. TODO(dbeam):

97 // write a streaming $i18n{} replacer and remove the "DisableI18n" part.	97 // write a streaming $i18n{} replacer and remove the "DisableI18n" part.

98 virtual void DisableI18nAndUseGzipForAllPaths() = 0;	98 virtual void DisableI18nAndUseGzipForAllPaths() = 0;

	99

	100 virtual void ExcludePathFromGzip(const std::string& path) = 0;
	Charlie Reis 2016/10/13 17:04:43 This is in content/public but doesn't appear to be This is in content/public but doesn't appear to be used outside content/. Can we just have it in the impl file until there's a use outside content? (Also, please add a comment if we leave it here.) http://www.chromium.org/developers/content-module/content-api "only expose methods in the public API that embedders need. If a method is only used by other code in content, it belongs in foo_impl.h and not foo.h" Dan Beam 2016/10/13 17:53:46 yep, sorry about that, most of the webui pages i m Show quoted text On 2016/10/13 17:04:43, Charlie Reis (Away till 10-14) wrote: > This is in content/public but doesn't appear to be used outside content/. Can > we just have it in the impl file until there's a use outside content? > > (Also, please add a comment if we leave it here.) > > http://www.chromium.org/developers/content-module/content-api > "only expose methods in the public API that embedders need. If a method is only > used by other code in content, it belongs in foo_impl.h and not foo.h" yep, sorry about that, most of the webui pages i mess with are in chrome/. one of them will probably eventually find the need for this, but until then: Done.
99 };	101 };

100	102

101 } // namespace content	103 } // namespace content

102	104

103 #endif // CONTENT_PUBLIC_BROWSER_WEB_UI_DATA_SOURCE_H_	105 #endif // CONTENT_PUBLIC_BROWSER_WEB_UI_DATA_SOURCE_H_

OLD	NEW