Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2399533003: Issue 27475. Discourage users from naming constructors the same as the enclosing classes. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 27475. Discourage users from naming constructors the same as the enclosing classes. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/27475 Committed: https://github.com/dart-lang/sdk/commit/5a4d7ebf6112e637dc1163f2f5964d7c25f4effd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -36 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 3 chunks +9 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 2 chunks +34 lines, -34 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 2 months ago (2016-10-05 16:25:11 UTC) #1
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-05 16:50:02 UTC) #2
scheglov
4 years, 2 months ago (2016-10-05 19:07:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a4d7ebf6112e637dc1163f2f5964d7c25f4effd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698